Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actor system #2584

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix actor system #2584

merged 1 commit into from
Sep 3, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 3, 2024

🦟 Bug fix

Summary

Follow up to #2577. Fixes the check for the case when the entity does not exist.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A bit of 🤦on my end

@arjo129 arjo129 merged commit c04a7d9 into gz-sim9 Sep 3, 2024
11 checks passed
@arjo129 arjo129 deleted the fix_actor branch September 3, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants