Revert behavior change introduced in #2452 #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR gazebosim#2452 changed the loading order of plugins attached to worlds and models. While the change is desirable, it changed the behavior of functions like `topicFromScopedName`. This reverts the behavior and the changes in associated tests. Signed-off-by: Addisu Z. Taddese <[email protected]>
|
looks like the touch plugin integration test is now failing. I can also reproduce it locally. |
The issue was not that world plugins are loaded after model plugins, but that previously, model plugins were called before the model's parent entity was set. Signed-off-by: Addisu Z. Taddese <[email protected]>
|
Okay, it turns out the plugin loading order was not the problem. World plugins were always loaded first. The issue was I'll say since the plugin loading order hasn't changed, this is not as a big of a breaking change as I had originally thought. |
|
Looks good. |
nkoenig
approved these changes
Aug 20, 2024
|
There was a failure on homebrew, but I think it's a flaky test (https://build.osrfoundation.org/job/gz_sim-ci-pr_any-homebrew-amd64/796/). Rerunning |
Merged
8 tasks
iche033
added a commit
that referenced
this pull request
Aug 27, 2024
Signed-off-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
PR #2452 changed the loading order of plugins attached to worlds and models. While the change is desirable, it changed the behavior of functions like
topicFromScopedName. This reverts the behavior and the changes in associated tests.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸