Merge gz-sim8 ➡️ main #2525
Merged
Merge gz-sim8 ➡️ main #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2474) Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
This test was generating a warning about unused vairables. Unless built in debug mode, `aserts`are often optimized out we should be using the `ASSERT` macros from `gtest` instead. Signed-off-by: Arjo Chakravarty <[email protected]>
n particular if a user despawns an entity, the associated plugin gets removed. This should prevent issues like #2165. TBH I'm not sure if this is the right way forward as a system should technically be able to access any entity in a traditional ECS. The PR has now been reworked and greatly simplified. All we do is stop all worker threads if an entity is removed and then recreate remaining threads.
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
* Fix #2458 - checking linkEnity is empty Signed-off-by: Abhiroop Bhavsar <[email protected]> * Update src/systems/user_commands/UserCommands.cc Co-authored-by: Arjo Chakravarty <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]> --------- Signed-off-by: Abhiroop Bhavsar <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]> Co-authored-by: Arjo Chakravarty <[email protected]>
* Check entity exists before attempting to add system Signed-off-by: Ian Chen <[email protected]> * warn to err, add todo Signed-off-by: Ian Chen <[email protected]> --------- Signed-off-by: Ian Chen <[email protected]>
* Clarfied description that was not clear due to rename Ignition to Gazebo. Signed-off-by: Johan Rutgeerts <[email protected]> * Slight rephrasing for extra clarity. Signed-off-by: Johan Rutgeerts <[email protected]> --------- Signed-off-by: Johan Rutgeerts <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Ian Chen <[email protected]>
* Use new ModelIdentifier::Url method --------- Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Ian Chen <[email protected]>
…n AckermannSteering plugin (#2521) Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
|
needs gazebosim/gz-fuel-tools#429 to be merged forward |
|
this is merged; manually restarting some CI jobs... |
iche033
approved these changes
Aug 14, 2024
|
I'm going to manually ignore the DCO failiure in order to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
gz-sim8➡️mainBranch comparison: main...gz-sim8
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)