Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Component Inspector Vector3d layout width fix #2195

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 6, 2023

🦟 Bug fix

Fixes #2192

Summary

Partial backport of #1680

  • Only backported the Vector3d layout width fix.
  • Pose3d left untouched since it seems to be working fine in ign-gazebo6 (on ubuntu) and there are quite a bit of changes in gz-sim7 so the fix may not apply to ign-gazebo6

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll merged commit 14b0f3b into ign-gazebo6 Oct 9, 2023
4 of 6 checks passed
@mjcarroll mjcarroll deleted the backport_gui_vector_fix branch October 9, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants