Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky RF comms test by relaxing the check for msg counter #1920

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 7, 2023

🦟 Bug fix

Summary

The INTEGRATION_rf_comms test occasionally fails on CI and is reproducible locally. The test publishes 10 msgs and expect all of them to be received. I believe it should not be the case since there is non-zero probability that msgs do get dropped (because rf_comms system is doing its job). There is some normal distribution used when computing the Rx power, and I noticed that when the Rx values fall below ~ -80 dBm, there is a chance that msgs get dropped.

I updated the integration test to pass if majority of the msgs (>50%) are received instead of all msgs.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner March 7, 2023 23:49
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 7, 2023
@iche033 iche033 requested a review from caguero March 7, 2023 23:49
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1920 (026e74e) into ign-gazebo6 (d1f9622) will not change coverage.
The diff coverage is n/a.

❗ Current head 026e74e differs from pull request most recent head 722cf81. Consider uploading reports for the commit 722cf81 to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1920   +/-   ##
============================================
  Coverage        65.08%   65.08%           
============================================
  Files              326      326           
  Lines            26660    26660           
============================================
  Hits             17352    17352           
  Misses            9308     9308           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit f8f6eee into ign-gazebo6 Mar 8, 2023
@mjcarroll mjcarroll deleted the fix_rf_comms_test branch March 8, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants