-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport cmdsim.rb: fix ruby syntax to ign-gazebo3 #1885
Conversation
This replaces File.exists? calls with File.exist? to fix the UNIT_gz_TEST on macOS. It also removes a rescue statement that was hiding useful error messages. Signed-off-by: Steve Peters <[email protected]>
hmm |
maybe it will be fixed once gazebosim/gz-fuel-tools#318 is released? |
I tested locally, and that appears to fix it. I've opened a PR to make a patch release of ign-fuel-tools 4.8.1 gazebosim/gz-fuel-tools#325 |
I just made the ign-fuel-tools 4.8.1 release and will restart CI |
the fuel tools 4.8.1 release didn't seem to fix the |
Signed-off-by: Steve Peters <[email protected]>
I believe the remaining CLI test is fixed by 34aadc8 |
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1885 +/- ##
===============================================
+ Coverage 77.98% 78.00% +0.01%
===============================================
Files 255 255
Lines 15041 15041
===============================================
+ Hits 11730 11732 +2
+ Misses 3311 3309 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Backport #1884. Part of #1867.
This replaces File.exists? calls with File.exist? to fix the UNIT_gz_TEST on macOS. It also removes a
rescue statement that was hiding useful error messages.
Note to maintainers: Remember to use Rebase-and-merge.