Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport cmdsim.rb: fix ruby syntax to ign-gazebo3 #1885

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Feb 6, 2023

Backport #1884. Part of #1867.

This replaces File.exists? calls with File.exist? to fix the UNIT_gz_TEST on macOS. It also removes a
rescue statement that was hiding useful error messages.

Note to maintainers: Remember to use Rebase-and-merge.

This replaces File.exists? calls with File.exist? to
fix the UNIT_gz_TEST on macOS. It also removes a
rescue statement that was hiding useful error messages.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from mjcarroll as a code owner February 6, 2023 23:56
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Feb 6, 2023
@scpeters scpeters enabled auto-merge (rebase) February 6, 2023 23:56
@iche033
Copy link
Contributor

iche033 commented Feb 7, 2023

hmm CmdLine.CachedFuelWorld is failing on ubuntu builds, not sure if it's related. Retriggered a couple of github actions

@scpeters
Copy link
Member Author

scpeters commented Feb 7, 2023

hmm CmdLine.CachedFuelWorld is failing on ubuntu builds, not sure if it's related. Retriggered a couple of github actions

maybe it will be fixed once gazebosim/gz-fuel-tools#318 is released?

@scpeters
Copy link
Member Author

scpeters commented Feb 7, 2023

hmm CmdLine.CachedFuelWorld is failing on ubuntu builds, not sure if it's related. Retriggered a couple of github actions

maybe it will be fixed once gazebosim/gz-fuel-tools#318 is released?

I tested locally, and that appears to fix it. I've opened a PR to make a patch release of ign-fuel-tools 4.8.1 gazebosim/gz-fuel-tools#325

@scpeters
Copy link
Member Author

scpeters commented Feb 8, 2023

I just made the ign-fuel-tools 4.8.1 release and will restart CI

@scpeters
Copy link
Member Author

scpeters commented Feb 8, 2023

the fuel tools 4.8.1 release didn't seem to fix the CmdLine.CachedFuelWorld test

@scpeters
Copy link
Member Author

scpeters commented Feb 8, 2023

the fuel tools 4.8.1 release didn't seem to fix the CmdLine.CachedFuelWorld test

I think we also need to backport 6acac79 from #1771

@scpeters scpeters disabled auto-merge February 8, 2023 16:36
@scpeters
Copy link
Member Author

I believe the remaining CLI test is fixed by 34aadc8

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #1885 (34aadc8) into ign-gazebo3 (1a61269) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@               Coverage Diff               @@
##           ign-gazebo3    #1885      +/-   ##
===============================================
+ Coverage        77.98%   78.00%   +0.01%     
===============================================
  Files              255      255              
  Lines            15041    15041              
===============================================
+ Hits             11730    11732       +2     
+ Misses            3311     3309       -2     
Impacted Files Coverage Δ
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
src/ServerConfig.cc 90.28% <ø> (ø)
src/ServerPrivate.cc 82.60% <0.00%> (ø)
src/World.cc 96.87% <ø> (ø)
src/network/NetworkManagerPrimary.cc 78.89% <ø> (ø)
...rc/systems/ackermann_steering/AckermannSteering.hh 100.00% <ø> (ø)
src/systems/altimeter/Altimeter.cc 73.17% <ø> (-0.33%) ⬇️
src/gui/AboutDialogHandler.cc 70.00% <100.00%> (+3.33%) ⬆️
src/Server.cc 86.14% <0.00%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit 940e5f3 into ign-gazebo3 Feb 11, 2023
@scpeters scpeters deleted the scpeters/backport_cmdline_macos branch February 11, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants