Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync View Angle GUI with view controller #1825

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Dec 1, 2022

🎉 New feature

Requires gazebosim/gz-gui#506

Summary

Syncs the View Angle GUI when the view controller may be set elsewhere (e.g., in the plugin configuration)

Test it

  1. Add <view_controller>ortho</view_controller> to:

    <plugin filename="MinimalScene" name="3D View">
    <ignition-gui>
    <title>3D View</title>
    <property type="bool" key="showTitleBar">false</property>
    <property type="string" key="state">docked</property>
    </ignition-gui>
    <engine>ogre2</engine>
    <scene>scene</scene>
    <ambient_light>0.4 0.4 0.4</ambient_light>
    <background_color>0.8 0.8 0.8</background_color>
    <camera_pose>-6 0 6 0 0.5 0</camera_pose>
    <camera_clip>
    <near>0.25</near>
    <far>25000</far>
    </camera_clip>
    </plugin>

  2. Run:

ign gazebo /path/to/minimal_scene.sdf
  1. Expand the View Angle plugin and you should see Orthographic View Control selected

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jennuine jennuine added the needs upstream release Blocked by a release of an upstream library label Dec 1, 2022
@jennuine jennuine requested review from ahcorde and iche033 December 1, 2022 00:19
@jennuine jennuine self-assigned this Dec 1, 2022
@jennuine jennuine requested a review from mjcarroll as a code owner December 1, 2022 00:19
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Dec 1, 2022
@jennuine jennuine changed the title updates gui with view cam controller Sync View Angle GUI with view controller Dec 1, 2022
@jennuine jennuine mentioned this pull request Dec 2, 2022
5 tasks
@jennuine jennuine merged commit ba96ec8 into ign-gazebo6 Dec 2, 2022
@jennuine jennuine deleted the jennuine/view_angle_update branch December 2, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress needs upstream release Blocked by a release of an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants