Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CLI Migration : gz-sim #1533

Merged
merged 3 commits into from
Jun 22, 2022
Merged

ign -> gz CLI Migration : gz-sim #1533

merged 3 commits into from
Jun 22, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jun 12, 2022
Closed
18 tasks
@methylDragon methylDragon marked this pull request as ready for review June 13, 2022 05:37
@methylDragon methylDragon added the needs upstream release Blocked by a release of an upstream library label Jun 13, 2022
@methylDragon
Copy link
Contributor Author

CI failure needs the merge of gz-tools so the gz executable is available

@methylDragon
Copy link
Contributor Author

methylDragon commented Jun 13, 2022 •
edited
Loading

Unsure what's happening with the segfault, I think it's the old issue with rendering

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 13, 2022
@methylDragon methylDragon force-pushed the cli_migration branch 2 times, most recently from fb57533 to de23558 Compare June 13, 2022 21:12
@methylDragon
Copy link
Contributor Author

image
image

image

@methylDragon
Copy link
Contributor Author

image
image

image

@chapulina chapulina added the 🌱 garden Ignition Garden label Jun 16, 2022
@methylDragon methylDragon force-pushed the cli_migration branch 4 times, most recently from c5020f0 to cf1914f Compare June 18, 2022 06:25
@methylDragon
Move CLI files
bcd416d 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate CLI
94c9527 
Signed-off-by: methylDragon <[email protected]>
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jun 22, 2022
chapulina
chapulina approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIT_gz_TEST passing for Linux and macOS, great work!

@chapulina chapulina merged commit 940bce8 into main Jun 22, 2022
@chapulina chapulina deleted the cli_migration branch June 22, 2022 21:37
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang mabelzhang is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina