Add desktop entry and svg logo #1411
Conversation
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1411 +/- ##
===============================================
+ Coverage 77.84% 77.88% +0.04%
===============================================
Files 250 250
Lines 14378 14378
===============================================
+ Hits 11192 11198 +6
+ Misses 3186 3180 -6
Continue to review full report at Codecov.
|
|
Oh I should have mentioned that I tried the pre-release and it worked for me 👍🏽 👍🏽 |
Signed-off-by: Jose Luis Rivero <[email protected]>
j-rivero
force-pushed
the
desktop_entry_ign_gazebo3
branch
from
5e1f68a to
5723a33
Compare
Signed-off-by: Jose Luis Rivero <[email protected]>
|
Tested new changes in: 3.13.0~pre3-1~focal is the prerelease repository for testing. |
Co-authored-by: Louise Poubel <[email protected]>
CMakeLists.txt
Outdated
| @@ -3,7 +3,7 @@ cmake_minimum_required(VERSION 3.10.2 FATAL_ERROR) | |||
| #============================================================================ | |||
| # Initialize the project | |||
| #============================================================================ | |||
| project(ignition-gazebo3 VERSION 3.12.0) | |||
| project(ignition-gazebo3 VERSION 3.13.0) | |||
There was a problem hiding this comment.
@j-rivero , I think it's cleaner if we do this in a separate PR and update the changelog as usual. It makes it easier to track the releases and then announce them, and also gives visibility to the team. How about:
- Reverting the version changes in this PR and merge it
- Opening a new PR for the stable release, with a changelog update including all the recent changes: ignition-gazebo3_3.12.0...ign-gazebo3
- Making a stable release
Signed-off-by: Jose Luis Rivero <[email protected]>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1 |
🎉 New feature
Part of gazebo-tooling/release-tools#598
Summary
Include a desktop entry for Ignition Gazebo in upstream sources: the PR is composed by two separate files, a desktop file conformant with version 1.0 of the standard. The other file is the Ignition logo in svg that illustrate the desktop entry.
A PR in the package metadata install the files in the corresponding directories.
Test it
New packages 3.13.0~pre1 are in the prerelease repository. They can be installed and open your desktop menu, search for Ignition and, depending on the desktop manager, will appear something like:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.