Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused variables in shapes plugin #1321

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Feb 3, 2022

🦟 Bug fix

Summary

Removed unused variables in shapes plugin

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from chapulina as a code owner February 3, 2022 21:19
@ahcorde ahcorde self-assigned this Feb 3, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1321 (2b24890) into ign-gazebo3 (ebb3a9a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3    #1321      +/-   ##
===============================================
- Coverage        77.19%   77.19%   -0.01%     
===============================================
  Files              227      227              
  Lines            13578    13578              
===============================================
- Hits             10482    10481       -1     
- Misses            3096     3097       +1     
Impacted Files Coverage Δ
src/gui/plugins/shapes/Shapes.cc 31.25% <ø> (ø)
src/Server.cc 84.33% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb3a9a...2b24890. Read the comment docs.

@ahcorde ahcorde merged commit e032208 into ign-gazebo3 Feb 4, 2022
@ahcorde ahcorde deleted the ahcorde/3/remove_unused_vars_shapes branch February 4, 2022 08:36
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants