Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to camera video record from subt #1117

Merged
merged 5 commits into from
Oct 20, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 18, 2021

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

Summary

Backports camera video recording updates from Dome that enables support for simtime recording. I've also added in a marker manager so that markers can be inserted into the scene used by the camera recorder.

This code was used to produce robot trajectory videos during subt.

Test it

The existing camera_video_record_dbl_pendulum.sdf should still work.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@nkoenig nkoenig requested a review from chapulina as a code owner October 18, 2021 16:56
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #1117 (2e39b5e) into ign-gazebo3 (9d0dfc3) will not change coverage.
The diff coverage is n/a.

❗ Current head 2e39b5e differs from pull request most recent head 13225b3. Consider uploading reports for the commit 13225b3 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3    #1117   +/-   ##
============================================
  Coverage        77.70%   77.70%           
============================================
  Files              222      222           
  Lines            12716    12716           
============================================
  Hits              9881     9881           
  Misses            2835     2835           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0dfc3...13225b3. Read the comment docs.

Signed-off-by: Nate Koenig <[email protected]>
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment question.

I think there will be some issues porting this across to fortress because the marker manager has been moved into ign-gui.

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig
Copy link
Contributor Author

nkoenig commented Oct 20, 2021

I think there will be some issues porting this across to fortress because the marker manager has been moved into ign-gui.

Yeah, I'll have to take a look at this when I forward port this PR.

@nkoenig nkoenig merged commit 0640db9 into ign-gazebo3 Oct 20, 2021
@nkoenig nkoenig deleted the camera_video_recorder_subt_updates branch October 20, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants