-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to camera video record from subt #1117
Conversation
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1117 +/- ##
============================================
Coverage 77.70% 77.70%
============================================
Files 222 222
Lines 12716 12716
============================================
Hits 9881 9881
Misses 2835 2835 Continue to review full report at Codecov.
|
Signed-off-by: Nate Koenig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment question.
I think there will be some issues porting this across to fortress
because the marker manager has been moved into ign-gui.
Signed-off-by: Nate Koenig <[email protected]>
Yeah, I'll have to take a look at this when I forward port this PR. |
Signed-off-by: Nate Koenig [email protected]
🎉 New feature
Summary
Backports camera video recording updates from Dome that enables support for simtime recording. I've also added in a marker manager so that markers can be inserted into the scene used by the camera recorder.
This code was used to produce robot trajectory videos during subt.
Test it
The existing
camera_video_record_dbl_pendulum.sdf
should still work.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge