changes baed on suggestions

Signed-off-by: root <[email protected]>
gazebosim · Jun 17, 2021 · 58a7bca · 58a7bca
1 parent b871fce
commit 58a7bca
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/systems/joint_controller/JointController.cc b/src/systems/joint_controller/JointController.cc
@@ -103,8 +103,10 @@ void JointController::Configure(const Entity &_entity,
   {
     ignerr << "Joint with name[" << this->dataPtr->jointName << "] not found. "
     << "The JointController will not control this joint.\n";
+    return;
   }
 
+  validConfig = true;
   if (_sdf->HasElement("initial_velocity"))
   {
     this->dataPtr->jointVelCmd = _sdf->Get<double>("initial_velocity");
@@ -185,17 +187,10 @@ void JointController::PreUpdate(const ignition::gazebo::UpdateInfo &_info,
   {
     ignwarn << "Detected jump back in time ["
         << std::chrono::duration_cast<std::chrono::seconds>(_info.dt).count()
-        << "s]. System may not work properly." << std::endl;
-  }
-
-  // If the joint hasn't been identified yet, look for it
-  if (this->dataPtr->jointEntity == kNullEntity)
-  {
-    this->dataPtr->jointEntity =
-        this->dataPtr->model.JointByName(_ecm, this->dataPtr->jointName);
+        << "s]. System will not work properly." << std::endl;
   }
 
-  if (this->dataPtr->jointEntity == kNullEntity)
+  if (!validConfig)
     return;
 
   // Nothing left to do if paused.

diff --git a/src/systems/joint_controller/JointController.hh b/src/systems/joint_controller/JointController.hh
@@ -98,6 +98,9 @@ namespace systems
 
     /// \brief Private data pointer
     private: std::unique_ptr<JointControllerPrivate> dataPtr;
+
+    /// \brief Private tells us if the configuration is considered valid
+    bool validConfig = false;
   };
   }
 }