Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about optix in README #425

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Add note about optix in README #425

merged 2 commits into from
Sep 27, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 24, 2021

🦟 Bug fix

Summary

Tweak to README about optix. Marked it as experimental since it's not very well maintained.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #425 (6e89b2d) into main (35087de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #425   +/-   ##
=======================================
  Coverage   55.11%   55.11%           
=======================================
  Files         192      192           
  Lines       19383    19383           
=======================================
  Hits        10682    10682           
  Misses       8701     8701           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35087de...6e89b2d. Read the comment docs.

@ahcorde ahcorde merged commit e465a98 into main Sep 27, 2021
@ahcorde ahcorde deleted the readme_tweak branch September 27, 2021 10:04
WilliamLewww pushed a commit to WilliamLewww/ign-rendering that referenced this pull request Dec 7, 2021
Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: William Lew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants