Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Fix Ogre2 Terra CI #412

Closed
wants to merge 107 commits into from
Closed

[Testing] Fix Ogre2 Terra CI #412

wants to merge 107 commits into from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 16, 2021

Do not merge!

Windows and homebrew CI builds for ogre2 Terra are failing. I'm testing here to try and get CI green.

ahcorde and others added 30 commits March 23, 2021 17:57
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>

Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
…ardware gamma to fix dark sky color

Signed-off-by: Ian Chen <[email protected]>
* Local updates for Ogre2.2 against main branch

Signed-off-by: Ian Chen <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
iche033 and others added 15 commits September 3, 2021 01:11
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
It should be destroyed before Ogre Root

Signed-off-by: Matias N. Goldberg <[email protected]>
This fixes some compiler bugs with Terra
Also adds supports for HlmsPbs::setShadowReceiversInPixelShader which
was written specifically for Gazebo

Signed-off-by: Matias N. Goldberg <[email protected]>
Signed-off-by: Matias N. Goldberg <[email protected]>
Update Terra to latest from upstream

Signed-off-by: Matias N. Goldberg <[email protected]>
Terra's workspace listener was being executed before the camera is
rotated for cubemap rendering

Signed-off-by: Matias N. Goldberg <[email protected]>
Silence warnings from external code to pass build checks

Signed-off-by: Matias N. Goldberg <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 marked this pull request as draft September 16, 2021 18:19
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 16, 2021
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #412 (bb0119b) into main (4bff736) will decrease coverage by 3.78%.
The diff coverage is 12.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   58.53%   54.74%   -3.79%     
==========================================
  Files         174      187      +13     
  Lines       17346    18890    +1544     
==========================================
+ Hits        10154    10342     +188     
- Misses       7192     8548    +1356     
Impacted Files Coverage Δ
...lude/ignition/rendering/ogre2/Ogre2RenderEngine.hh 100.00% <ø> (ø)
ogre2/src/Ogre2Heightmap.cc 0.00% <0.00%> (ø)
ogre2/src/terrain/Terra/include/Terra/Terra.h 0.00% <0.00%> (ø)
...rc/terrain/Terra/include/Terra/TerraShadowMapper.h 0.00% <0.00%> (ø)
...gre2/src/terrain/Terra/include/Terra/TerrainCell.h 0.00% <0.00%> (ø)
...rain/Terra/src/Hlms/OgreHlmsTerraDatablock.cpp.inc 0.00% <0.00%> (ø)
ogre2/src/terrain/Terra/src/Terra.cpp 0.00% <0.00%> (ø)
ogre2/src/terrain/Terra/src/TerraShadowMapper.cpp 0.00% <0.00%> (ø)
ogre2/src/terrain/Terra/src/TerrainCell.cpp 0.00% <0.00%> (ø)
ogre2/src/terrain/Terra/src/Hlms/OgreHlmsTerra.cpp 14.62% <14.62%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bff736...bb0119b. Read the comment docs.

Signed-off-by: Ian Chen <[email protected]>
@chapulina chapulina added beta Targeting beta release of upcoming collection ogre2.x labels Sep 18, 2021
@iche033
Copy link
Contributor Author

iche033 commented Sep 20, 2021

fixes are manually merged into #386

@iche033 iche033 closed this Sep 20, 2021
@iche033 iche033 deleted the iche033/ogre22-terra branch March 7, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏯 fortress Ignition Fortress ogre2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants