Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved doxygen #389

Merged
merged 8 commits into from
Aug 30, 2021
Merged

Improved doxygen #389

merged 8 commits into from
Aug 30, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 26, 2021

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Improved doxygen and added CI linter

Test it

In the build directory run:

make doc
bash <(curl -s https://raw.githubusercontent.com/ignitionrobotics/ign-cmake/ign-cmake2/tools/doc_check.sh)

Checklist

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde self-assigned this Aug 26, 2021
@ahcorde ahcorde requested a review from iche033 as a code owner August 26, 2021 08:59
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #389 (df489a6) into ign-rendering3 (99c08c5) will not change coverage.
The diff coverage is 60.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering3     #389   +/-   ##
===============================================
  Coverage           53.35%   53.35%           
===============================================
  Files                 131      131           
  Lines               12036    12036           
===============================================
  Hits                 6422     6422           
  Misses               5614     5614           
Impacted Files Coverage Δ
include/ignition/rendering/Camera.hh 100.00% <ø> (ø)
include/ignition/rendering/Geometry.hh 100.00% <ø> (ø)
include/ignition/rendering/GpuRays.hh 0.00% <ø> (ø)
include/ignition/rendering/Light.hh 100.00% <ø> (ø)
include/ignition/rendering/Material.hh 100.00% <ø> (ø)
include/ignition/rendering/Mesh.hh 100.00% <ø> (ø)
include/ignition/rendering/RayQuery.hh 100.00% <ø> (ø)
include/ignition/rendering/RenderEngine.hh 100.00% <ø> (ø)
include/ignition/rendering/Scene.hh 0.00% <ø> (ø)
include/ignition/rendering/Storage.hh 25.00% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c08c5...df489a6. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

include/ignition/rendering/Visual.hh Show resolved Hide resolved
Signed-off-by: ahcorde <[email protected]>
@chapulina chapulina merged commit 08ee26c into ign-rendering3 Aug 30, 2021
@chapulina chapulina deleted the ahcorde/improved/doxygen branch August 30, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants