Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test coverage: Heightmaps on all cameras #546

Open
3 of 7 tasks
darksylinc opened this issue Jan 23, 2022 · 0 comments
Open
3 of 7 tasks

Unit test coverage: Heightmaps on all cameras #546

darksylinc opened this issue Jan 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@darksylinc
Copy link
Contributor

darksylinc commented Jan 23, 2022 •
edited
Loading

After merging PR #545, codeconv reports lower coverage because the heightmap is not being tested in any sensor:

  • Ogre2MaterialSwitcher (e.g. VisualAt / SelectionBuffer)
  • Ogre2LaserRetroMaterialSwitcher
  • Ogre2SegmentationMaterialSwitcher
  • Ogre2ThermalCameraMaterialSwitcher
    • Heightmap is a background object (i.e. has no thermal value defined, uses ambient/color instead)
    • Heightmap has an explicit thermal value specified
    • Heightmap does not support heat map texture setting. Unit test should test we properly abort/complain if user requests it.

These tests can only be implemented in Garden, not Fortress (as Heightmap doesn't work with those sensors in Fortress, we just disable the terrain as a workaround).

A unit test (or extending existing tests) to cover the heightmap with each sensor should be written.

This is very low priority for me and anyone can implement it.
@darksylinc darksylinc added the enhancement New feature or request label Jan 23, 2022
@darksylinc darksylinc mentioned this issue Jan 23, 2022
Merged
7 tasks
@darksylinc darksylinc mentioned this issue Dec 10, 2022
Merged
8 tasks
iche033 added a commit that referenced this issue Dec 28, 2022
@darksylinc @iche033
Add Heightmap integration test (#785)
4de8d1e 
This PR adds a heightmap test.

Almost all issues in #546 are covered.

Only Thermal Camera is not covered.

Fixes #332 (again) for macOS and possibly any OS/HW/Driver combination.
Fixes #369

Signed-off-by: Matias N. Goldberg <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@darksylinc