-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dataframe message #238
Conversation
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-msgs8 #238 +/- ##
==========================================
Coverage 85.38% 85.38%
==========================================
Files 9 9
Lines 951 951
==========================================
Hits 812 812
Misses 139 139 Continue to review full report at Codecov.
|
{ | ||
/// \brief Header data. | ||
Header header = 1; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While a header with the correct time stamp and the source and destination addresses are sufficient for the MBZIRC use case, we should also log the position of where the message is starting from this is useful for the MBARI use case. The reason is that the message take in the order of a few seconds to propagate hence it would help if the original position were logged as the vehicle may have moved in this time frame.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to store that information in the specific comms model during the step that's supposed to process this message for the first time? In addition, the client might not know its own location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's one possibility, but it would lead to very complicated code. We probably can revisit this afterwards.
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
🎉 New feature
Required by
Summary
This is a message to mimic a data frame used to send and receive data over the network.
Test it
You can test it via gazebosim/gz-sim#1416
Note: This is ready to review but do not merge it yet please. I'm working on a Gazebo system that will use this message and want to confirm that no extra fields are needed.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸