Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edifice tutorial updates #204

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Edifice tutorial updates #204

merged 2 commits into from
Mar 29, 2021

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Mar 29, 2021

Summary

Checklist

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine requested a review from chapulina as a code owner March 29, 2021 22:04
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #204 (80cc15d) into main (c72f4f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          24       24           
  Lines        3069     3069           
=======================================
  Hits         1785     1785           
  Misses       1284     1284           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72f4f7...80cc15d. Read the comment docs.

@jennuine jennuine marked this pull request as draft March 29, 2021 22:08
@jennuine jennuine marked this pull request as ready for review March 29, 2021 22:22
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It only took us 5 major versions to clean up version 0 docs! 😅

@chapulina chapulina added the documentation Improvements or additions to documentation label Mar 29, 2021
@chapulina chapulina merged commit 83d4f2a into main Mar 29, 2021
@chapulina chapulina deleted the jennuine/tutorial_updates branch March 29, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants