Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error output when creating directories #561

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

mjcarroll
Copy link
Contributor

Found when debugging some of the Windows CI failures in fuel_tools here: gazebosim/gz-fuel-tools#392

Instead of getting the output routed to gzerr, instead the macro gets expanded incorrectly yielding only:

7: [ RUN      ] CmdLine.ModelDownloadUnversioned
7: C:\J\workspace\gz_fuel_tools-pr-win\ws\gz-fuel-tools\src\gz_src_TEST.cc(195): error: Value of: this->stdErrBuffer.str().empty()
7:   Actual: false
7: Expected: true
7: �[31m[Err] [C:\J\workspace\gz_fuel_tools-pr-win\ws\gz-common\src\Filesystem.cc:469] �[m�[31m[Err] [C:\J\workspace\gz_fuel_tools-pr-win\ws\gz-common\src\Filesystem.cc:469] �[m�[31m[Err] [C:\J\workspace\gz_fuel_tools-pr-win\ws\gz-common\src\Filesystem.cc:469] �[m�[31m[Err] [C:\J\workspace\gz_fuel_tools-pr-win\ws\gz-common\src\Filesystem.cc:469] �[m�[31m[Err] [C:\J\workspace\gz_fuel_tools-pr-win\ws\gz-common\src\Filesystem.cc:469] �[m

@mjcarroll mjcarroll requested a review from marcoag as a code owner December 4, 2023 15:51
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Dec 4, 2023
@mjcarroll mjcarroll merged commit e899db5 into ign-common3 Dec 4, 2023
8 of 9 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/fix_errout branch December 4, 2023 16:51
@mjcarroll mjcarroll self-assigned this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants