Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 ➡️ 4 #246

Merged
merged 8 commits into from
Sep 9, 2021
Merged

3 ➡️ 4 #246

merged 8 commits into from
Sep 9, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-common3 to ign-common4

Branch comparison: ign-common4...ign-common3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 8 commits April 21, 2020 15:18
@chapulina
[ign-common1] Update BitBucket links (#55)
7bad35a 
* [ign-common1] Update BitBucket links

Signed-off-by: Louise Poubel <[email protected]>

* [ign-common1] Update BitBucket links

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
[ign-common1] Workflow updates (#62)
1fb5c8c 
Signed-off-by: Louise Poubel <[email protected]>
@azeey
Fix segfault caused by destruction order of Event and Connection (#234)
1c1eec8 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@mahiuchun @mjcarroll
Fix a typo in VideoEncoder_TEST. (#231)
3bff8ac 
Signed-off-by: Hill Ma <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>

Co-authored-by: Michael Carroll <[email protected]>
@chapulina
👩‍🌾 Remove bitbucket-pipelines (#241)
4a1f1d9 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
1 ➡️ 3
717f7f3 
Signed-off-by: Louise Poubel <[email protected]>
@mjcarroll
1 ➡️ 3 (#242)
d9d8df2 
1 ➡️ 3
@chapulina
3 to 4
3abfa78 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
@chapulina chapulina requested a review from mjcarroll as a code owner September 8, 2021 17:49
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Sep 8, 2021
@chapulina chapulina mentioned this pull request Sep 8, 2021
Closed
@codecov
Copy link

codecov bot commented Sep 8, 2021 •
edited
Loading

Codecov Report

Merging #246 (3abfa78) into ign-common4 (4c0ee89) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-common4     #246      +/-   ##
===============================================
+ Coverage        77.02%   77.03%   +0.01%     
===============================================
  Files               74       74              
  Lines            10579    10586       +7     
===============================================
+ Hits              8148     8155       +7     
  Misses            2431     2431
Impacted Files Coverage Δ
events/include/ignition/common/Event.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0ee89...3abfa78. Read the comment docs.

@Blast545 Blast545 mentioned this pull request Sep 9, 2021
Merged
@mjcarroll mjcarroll merged commit 9694f89 into ign-common4 Sep 9, 2021
@mjcarroll mjcarroll deleted the chapulina/3_to_4 branch September 9, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chapulina @mjcarroll @azeey @mahiuchun