Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new Fortress branches to ABI checker #523

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Adding new Fortress branches to ABI checker #523

merged 2 commits into from
Sep 28, 2021

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Sep 28, 2021

Needed here: gazebosim/gz-msgs#186

@caguero
Adding msgs8 to ABI checker
d95c163 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero requested a review from j-rivero as a code owner September 28, 2021 15:28
@caguero caguero mentioned this pull request Sep 28, 2021
Merged
7 tasks
@chapulina
Update all Fortress versions
cb63063 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina changed the title Adding msgs8 to ABI checker Adding new Fortress branches to ABI checker Sep 28, 2021
chapulina
chapulina approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and added all Fortress branches in cb63063

@chapulina chapulina merged commit ccca72d into master Sep 28, 2021
@chapulina chapulina deleted the caguero/msgs8 branch September 28, 2021 16:02
@scpeters
Copy link
Contributor

FYI this also creates all the release branch CI jobs, which will fail if the release branches have not yet been created. We can ignore them for now:

@chapulina chapulina mentioned this pull request Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caguero @scpeters @chapulina