Improver1537 emos plugins2 #15
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow a required module.
…atic additional predictor.
…tatic additional predictor.
Codecov Report
@@ Coverage Diff @@
## improver_1537_crps_minimisers #15 +/- ##
=================================================================
+ Coverage 97.98% 98.00% +0.02%
=================================================================
Files 107 107
Lines 9611 9669 +58
=================================================================
+ Hits 9417 9476 +59
+ Misses 194 193 -1
Continue to review full report at Codecov.
|
metoppv#1573) * Spot extraction modified to work with multi-dimensional aux coords. To be able to spot extract local-timezone maximum temperatures and UV indexes from the global grid the spot-extraction code has been modified to work with 2-D time coordinates. The time coordinate value associated with each spot site is extracted from the 2-D grid and a 1-D coordinate associated with the spot-index is created. * Add units tests for SpotExtraction components. * Add acceptance test. * Updated compare CLI acceptance test to work when using new global neighbour cube. * Review changes. * Checksum updated. * Simplified code along lines suggested in review. * Makes 2-d time coordinates for test with expected units. This is just to make things consistent between real world usage and tests. The existing code to generate time coordinates only deals with single dimensions, so here the _create_time_point code is invoked and the custom coordinate constructed.
…on plugin (metoppv#1575) * Only the changes required to the ContinuousRankedProbabilityScoreMinimisers plugin required to support the use of additional predictors. * Simplified array reshaping functionality. * Update docstrings. * Edits following review comments. * Correct test name. * Modification follwing review comments. * Move methods to makes the process method the final method in the class. * flake8 corrections. * Modify docstring. * Move predictor argument to init. Co-authored-by: fionaRust <[email protected]>
…_plugins2 * upstream/master: Support for a static additional predictor within the CRPS minimisation plugin (metoppv#1575) MOBT-86: Spot extracting from data with 2-dimensional time coordinates (metoppv#1573)
…ditional predictor handling in relation to the initial guess.
…ering (metoppv#1580) * Modify EnsembleReordering output to retain ensemble realization numbers from the raw forecast. * Update improver_tests/ensemble_copula_coupling/test_EnsembleReordering.py Co-authored-by: Stephen Moseley <[email protected]> * Apply black. Co-authored-by: Stephen Moseley <[email protected]>
…_plugins2 * upstream/master: Retain ensemble realization numbers from the raw forecast after reordering (metoppv#1580)
* Modify the leniency of the forecast period check to support calibrating forecasts from subhourly cycles with coefficients produced on the hour. Also, skip spatial domain checking for spot forecasts. * Corrections and extensions to find the ceiling of the forecast period and add acceptance test for an example. * Modifications following review comments. * Updates to docstrings. * Update checksums. * Update improver_tests/calibration/utilities/test_utilities.py Co-authored-by: fionaRust <[email protected]> Co-authored-by: fionaRust <[email protected]>
…_plugins2 * upstream/master: Increase leniency of EMOS application (metoppv#1577)
gavinevans
force-pushed
the
improver1537_emos_plugins2
branch
2 times, most recently
from
dce97d1 to
1215468
Compare
gavinevans
force-pushed
the
improver1537_emos_plugins2
branch
from
1215468 to
c663df5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR shows the differences between the branch containing the modification to the CRPS minimisation and the branch containing a fuller set of changes.
Testing: