[v2] Add gatsby-remark-bracketed-spans plugin #8044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimshvetsov
changed the title
vadimshvetsov
changed the title
|
I ran |
|
Normally users publish & maintain such packages by themself and they don’t get merged into Gatsby |
|
@LekoArts There is a very similar package already in Gatsby - https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-remark-custom-blocks |
|
I still can't pass snapshot test. I've ran every possible shapshot update script including |
KyleAMathews
force-pushed
the
master
branch
5 times, most recently
from
fc4ca3e to
2116fff
Compare
|
I've published package and it's not working as intended. I'll dive into this but now this PR wouldn't profitable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of remark-bracketed-spans parser plugin for using id and other attributes with spans.
I'm not fluent with gatsby plugin infrastructure and my attempts to bind this in dev mode with test site was failed. I would appreciate any advices about how to do it and why
npm run watch -- --scope=gatsby-remark-bracketed-spansfailing.