-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added StaticQuery Explanation in Tutorial-part-4 #6915
Conversation
Deploy preview for using-postcss-sass failed. Built with commit db220dd https://app.netlify.com/sites/using-postcss-sass/deploys/5b683921c9659271652eaf08 |
Deploy preview for gatsbygram ready! Built with commit db220dd |
Deploy preview for using-drupal ready! Built with commit db220dd |
@Chuloo can we add something short to this that explains more explicitly the difference between a |
@amberleyromo I tried to come up with something short to add here (based on https://next.gatsbyjs.org/docs/static-query/#how-staticquery-differs-from-page-query) but found it kinda tricky to describe should this section of the tutorial should be rewritten to introduce The "Querying for the site title" section could be split into:
Do you think it's worth opening an issue to do this? Also note this issue that talks about ways that Gatsby could make the two different types of query easier to understand: #6596 |
Oh haha I just realised there's some related changes in #6892 |
I do think it's worth opening an issue to do this, personally. I agree that introducing them together is a lot in one go. Good to read through the issue you linked (#6596) -- What would you say the likelihood of a shift like this would be before v2 launch? (For context in prioritizing doc work). I'm happy to run with this, if y'all want. @Chuloo @m-allanson? |
I opened #7059 to follow up on this discussion.
I think this should happen before v2 release, so I marked that issue as a blocker for v2, but let's see if @shannonbux or @KyleAMathews disagree.
Sounds great to me - although probably best to get confirmation from @shannonbux before getting started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Chuloo 👍
I updated this to include a link to the StaticQuery docs.
Deploy preview for gatsbyjs failed. Built with commit db220dd https://app.netlify.com/sites/gatsbyjs/deploys/5b683920c9659271652eaefc |
@m-allanson quick point of clarification:
I didn't mean writing the docs, I meant the potential shift described in #6596. (The new issue, #7059, addressing the docs specifically). So if that shift was going to happen before v2 goes stable, I was going to wait on those docs. |
#6596 def won't happen before release (if ever, needs investigating). |
Ahh that makes sense, sorry for the confusion @amberleyromo. I'm going to merge this in, and we can follow up with #7059 |
* Added StaticQuery explanation in tutorial part 4 * Added StaticQuery explanation in tutorial part 4 * Added StaticQuery explanation in tutorial part 4 * Add link to StaticQuery docs
Here's a one-liner explaining the usage of StaticQuery to query data in components using GraphQL.