Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent search shortcut from breaking other input elements #3777

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Prevent search shortcut from breaking other input elements #3777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion www/src/components/search-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,10 @@ class SearchForm extends Component {

focusSearchInput(e) {
if (e.key !== `s`) return
if (document.activeElement === this.searchInput) return // eslint-disable-line no-undef

// ignore this shortcut whenever an <input> has focus
if (document.activeElement instanceof window.HTMLInputElement) return // eslint-disable-line no-undef

e.preventDefault()
this.searchInput.focus()
}
Expand Down