Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ssh git urls for starters #3690

Merged
merged 2 commits into from
Jan 25, 2018

Conversation

VinSpee
Copy link
Contributor

@VinSpee VinSpee commented Jan 25, 2018

use hosted-git-info's ssh url. This allows starters from private repos
to work while still supporting the defaults and public starters.

use `hosted-git-info`'s ssh url. This allows starters from private repos
to work while still supporting the defaults and public starters.
@KyleAMathews
Copy link
Contributor

@jquense do you remember any reason why we didn't go with this?

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jan 25, 2018

Deploy preview for gatsbygram ready!

Built with commit 2174cca

https://deploy-preview-3690--gatsbygram.netlify.com

@VinSpee
Copy link
Contributor Author

VinSpee commented Jan 25, 2018

I tested it with the default starter (empty) and with https://github.com/haysclark/gatsby-starter-casper and both still worked as expected

@ghost ghost assigned KyleAMathews Jan 25, 2018
@ghost ghost added the review label Jan 25, 2018
@KyleAMathews
Copy link
Contributor

Looked through the docs and let's just use getDefaultRepresentation()

Returns the default output type. The default output type is based on the string you passed in to be parsed

That way we won't just switch problems to where we're not forcing git on people which breaks edge cases where https is necessary.

@KyleAMathews KyleAMathews merged commit 466aad7 into gatsbyjs:master Jan 25, 2018
@ghost ghost removed the review label Jan 25, 2018
KyleAMathews added a commit that referenced this pull request Jan 26, 2018
KyleAMathews added a commit that referenced this pull request Jan 26, 2018
@jlengstorf
Copy link
Contributor

Hiya @VinSpee! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

@VinSpee
Copy link
Contributor Author

VinSpee commented Feb 16, 2019

@jlengstorf Awesome! Thanks for the amazing work, not only on Gatsby the tool, but on the community as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants