Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-telemetry): Include a boolean flag to telemetry data whether gatsby is running in docker or not. #13246

Merged
merged 1 commit into from
Apr 9, 2019
Merged

feat(gatsby-telemetry): Include a boolean flag to telemetry data whether gatsby is running in docker or not. #13246

merged 1 commit into from
Apr 9, 2019

Conversation

jamo
Copy link
Contributor

@jamo jamo commented Apr 9, 2019

@lannonbr lannonbr changed the title Include a boolean flag to telemetry data whether gatsby is running in docker or not. feat(gastby-telemetry): Include a boolean flag to telemetry data whether gatsby is running in docker or not. Apr 9, 2019
@jamo
Copy link
Contributor Author

jamo commented Apr 9, 2019

Not sure what the failing test is about

 1) navigation non-existant route "before each" hook:
     Uncaught Error: Uncaught Uncaught Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

I can't quite see any correlation with what I did and with the test failure

@DSchau
Copy link
Contributor

DSchau commented Apr 9, 2019

@jamo I think the aptly/funnily named [do not merge] just testing is the fix. --copy-all seems to not hoist the packages correctly.

Don't worry about the tests failing!

@DSchau DSchau changed the title feat(gastby-telemetry): Include a boolean flag to telemetry data whether gatsby is running in docker or not. feat(gatsby-telemetry): Include a boolean flag to telemetry data whether gatsby is running in docker or not. Apr 9, 2019
DSchau
DSchau approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable! Thanks!

@DSchau DSchau merged commit f07147a into master Apr 9, 2019
@DSchau DSchau deleted the telemetry-docker branch April 9, 2019 14:36
@DSchau
Copy link
Contributor

DSchau commented Apr 9, 2019

Successfully published:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamo @DSchau