Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix references to react-helmet usage #11690

Merged
merged 3 commits into from
Feb 15, 2019
Merged

Conversation

gurpreet-hanjra
Copy link
Contributor

@gurpreet-hanjra gurpreet-hanjra commented Feb 11, 2019

Update references to react-helmet-

  1. Update link to package-readme.js because layout.js is not using react-helmet anymore.
  2. Remove reference to Jason Lengstorf’s personal website because it's not using react-helmet package

Description

Related Issues

Update references to `react-helmet`- 
1. Update link to `package-readme.js` because `layout.js` is not using `react-helmet` anymore.
2. Remove reference to `Jason Lengstorf’s personal website` because it's to using react-helmet package
@gurpreet-hanjra gurpreet-hanjra requested a review from a team February 11, 2019 11:00
@m-allanson m-allanson changed the title (docs) - Fix references to react-helmet usage docs: Fix references to react-helmet usage Feb 11, 2019
@marcysutton
Copy link
Contributor

@jlengstorf does your site not use react-helmet anymore? I see some references to it in your rendered site, but not in the source.

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: oops I wrote this comment and then didn't post it until the next day. 😬 So didn't see Marcy's comment until just now.

Thanks @gurpreet-hanjra 👍

@jlengstorf recently updated his site to use Gatsby themes. So his usage of react-helmet can be found over here: https://github.com/jlengstorf/gatsby-theme-jason-blog/blob/master/src/components/SEO/SEO.js

Maybe linking to the seo component in the default starter could be handy too? https://github.com/gatsbyjs/gatsby/blob/master/starters/default/src/components/seo.js

1. add reference to default starter
2. add reference Jason's blog
@gurpreet-hanjra
Copy link
Contributor Author

Thank you @m-allanson . Changes are done.

@m-allanson m-allanson dismissed their stale review February 12, 2019 17:32

PR updated

Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @m-allanson said. 😄

This looks good to me. I'll let @marcysutton do the final approval, though.

@gurpreet-hanjra
Copy link
Contributor Author

gurpreet-hanjra commented Feb 14, 2019

@marcysutton waiting for your final approval :)

@jlengstorf jlengstorf merged commit e651e9c into master Feb 15, 2019
@jlengstorf jlengstorf deleted the gurpreet-hanjra-patch-1 branch February 15, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants