[gatsby-source-contentful] gatsby-plugin-image should be a peerDep

[slk333]

Hello!

On this documentation page:
https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-source-contentful#using-the-new-gatsby-image-plugin

The documentation currently states:

1. Install the plugins:
   npm install gatsby-plugin-image gatsby-plugin-sharp

But gatsby-plugin-image is already a dependency of gatsby-source-contentful, and it works fine without the redundant install.

I didn't open a Pull Request because I'm not sure if this is intended or not.

Thanks

[LekoArts]

Hey, thanks for the issue! The docs are correct here, gatsby-plugin-image should be installed as it really should be a peerDependency not a direct dependency.

[axe312ger]

Good find, thats outdated. Readme should not contain the install for gatsby-plugin-sharp

[axe312ger]

@LekoArts no, we need it as a dependency in the plugin.

[LekoArts]

Why is that? @ascorbic documented it differently: https://www.gatsbyjs.com/docs/how-to/plugins-and-themes/adding-gatsby-image-support/#other-considerations

gatsby-plugin-sharp is a peerDep

[axe312ger]

It was required when implementing gatsby-plugin-image. Now it is not anymore ¯_(ツ)_/¯

So yeah, can become a peer dep. Checked the code, all requires should check if the plugin is actually installed

[ascorbic]

@axe312ger The docs are correct: it should be a peerDependency and a devDependency.

[axe312ger]

@ascorbic both? 🤔

[ascorbic]

You can probably skip the devDependency, as you're in the monorepo, but it's for whiel you're developing.

[axe312ger]

PR incoming