Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick rel-v0.55] Fix installation of gosec and addlicense (#957) #958

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[Cherry-pick rel-v0.55] Fix installation of gosec and addlicense (#957) #958

merged 1 commit into from
Dec 2, 2024

Conversation

thiyyakat
Copy link
Contributor

What this PR does / why we need it:
This PR is a cherry-pick of PR #957.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed `addlicense` and  `gosec` installation.

Updated go lang to version `1.23.3`

@thiyyakat @rishabh-11
Fix installation of gosec and addlicense (gardener#957)
b03ca47 
* Change values and names of variables used in tools.mk file to fix bug in gosec and addlicense installation

* run make generate

* Update go version to v1.23.3

---------

Co-authored-by: Rishabh Patel <[email protected]>
@thiyyakat thiyyakat requested a review from a team as a code owner December 2, 2024 10:57
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Dec 2, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 2, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 2, 2024
rishabh-11
rishabh-11 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 2, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 2, 2024
@rishabh-11 rishabh-11 merged commit f1d8b1a into gardener:rel-v0.55 Dec 2, 2024
3 of 5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 2, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thiyyakat @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot