-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check, update node label on machine obj prior to drain,termination #887
Conversation
Teested fix on GCP (node label is same as machine name for this provider). Removed the
|
Teested fix on AWS (node label is diff from machine name for this provider). Removed the node label and initiated machine deletion. Node label is now set again prior to drain and deletion. Node deletion successfully occurs even when node label is missing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some log changes requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
When a Node is never associated with its Machine. Ie the machine object never has the
machine.Labels[v1alpha1.NodeLabelKey]
set after the machine creation, then during the deletion flow, our Node object is not deleted. (Label updation can be missed if the machine object update transiently fails)Then after some time, the dangling Node object gets the
NotManagedByMCM
annotation.Which issue(s) this PR fixes:
Fixes #875
Special notes for your reviewer:
Release note: