Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apiVersion: v1 to gardener-extension-admission-cilium ServiceAccount #241

Merged

Conversation

plkokanov
Copy link
Contributor

How to categorize this PR?

/area networking
/kind bug

What this PR does / why we need it:
With #234 the apiVersion field was removed from charts/gardener-extension-admission-cilium/charts/runtime/templates/serviceaccount.yaml.

This causes the following error when using these charts to deploy the admission with the local gardener setup with extensions:

[error validating data: apiVersion not set; if you choose to ignore these errors, turn validation off with --validate=false](error: error validating "/var/folders/bh/hg7dql3d335b8bbcfz7t242h0000gn/T/tmp.b0KmJ2olbv/runtime-resources.yaml": error validating data: apiVersion not set; if you choose to ignore these errors, turn validation off with --validate=false)

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Release note:

Fixed a validation error which occurs when deploying the `gardener-extension-admission-cilium` charts because of a missing `apiVersion` field in its `charts/gardener-extension-admission-cilium/charts/runtime/templates/serviceaccount.yaml` file.

@plkokanov plkokanov requested review from a team as code owners February 7, 2024 11:31
@gardener-robot gardener-robot added needs/review Needs review area/networking Networking related kind/bug Bug size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 7, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 7, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 7, 2024
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 7, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 7, 2024
Copy link

gardener-prow bot commented Feb 7, 2024

@plkokanov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-extension-networking-cilium-e2e-kind fb85f8e link true /test pull-extension-networking-cilium-e2e-kind

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@DockToFuture DockToFuture merged commit e0f96d0 into gardener:master Feb 7, 2024
7 of 8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants