Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cilium to v1.14.5 #235

Merged
merged 1 commit into from
Jan 11, 2024
Merged

update cilium to v1.14.5 #235

merged 1 commit into from
Jan 11, 2024

Conversation

DockToFuture
Copy link
Member

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
Update cilium to v1.14.5.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Update cilium to `v1.14.5`.

@DockToFuture DockToFuture requested review from a team as code owners January 10, 2024 14:06
@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 10, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 10, 2024
ScheererJ
ScheererJ reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at changes in install/kubernetes/cilium in cilium/cilium@v1.14.4...v1.14.5/install/kubernetes/cilium, there are a few changes in the manifests that allow changing some configuration paramters via values.yaml, e.g. resource requests or volume mounts. Do we want to take that over as well to be closer to the source?

@DockToFuture
Copy link
Member Author

Looking at changes in install/kubernetes/cilium in cilium/[email protected]/install/kubernetes/cilium, there are a few changes in the manifests that allow changing some configuration paramters via values.yaml, e.g. resource requests or volume mounts. Do we want to take that over as well to be closer to the source?

I would leave the PR as it is as the fields are not used right now and plead to adapt the cilium charts at a later point in time in a separate PR.

ScheererJ
ScheererJ approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 11, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 11, 2024
@DockToFuture DockToFuture added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 11, 2024
@DockToFuture
Copy link
Member Author

DockToFuture commented Jan 11, 2024 •
edited
Loading

/retest

@DockToFuture DockToFuture merged commit 581956c into gardener:master Jan 11, 2024
8 checks passed
@DockToFuture DockToFuture deleted the update/cilium-v1.14.5 branch January 11, 2024 15:24
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 11, 2024
robertvolkmann pushed a commit to metal-stack/gardener-extension-networking-cilium that referenced this pull request May 7, 2024
@DockToFuture @robertvolkmann
update cilium to v1.14.5 (gardener#235)
724ebb7 
(cherry picked from commit 581956c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DockToFuture @ScheererJ @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot