Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wait for MR to get deleted in case of force-delete #227

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Don't wait for MR to get deleted in case of force-delete #227

merged 1 commit into from
Nov 2, 2023

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
Follow up - #213

This PR enhances the delete function so that it doesn't wait for MR to be gone in case of force-delete.

/invite @acumino

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `actuator.Delete` doesn't wait for ManagedResources to get deleted in case of `ForceDelete`.

@shafeeqes shafeeqes requested review from a team as code owners October 31, 2023 05:53
@gardener-robot gardener-robot added the needs/review Needs review label Oct 31, 2023
@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 31, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 31, 2023
acumino
acumino reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 31, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 31, 2023
@axel7born axel7born merged commit 2528149 into gardener:master Nov 2, 2023
1 check passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 2, 2023
@shafeeqes shafeeqes deleted the enh/fd branch November 7, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino acumino left review comments

@axel7born axel7born axel7born approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shafeeqes @axel7born @acumino @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot