Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't deploy PSPs when PodSecurityPolicy plugin is disabled #120

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Don't deploy PSPs when PodSecurityPolicy plugin is disabled #120

merged 4 commits into from
Aug 22, 2022

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/area networking
/area open-source
/kind enhancement

What this PR does / why we need it:
PodSecurityPolicy is deprecated and will be disabled in kubernetes v1.25+.
End-users are provided an option to migrate their PSPs before upgrading and disable the PodSecurityPolicy admission plugin in the ShootSpec.
In that case, we should stop deploying our PSPs as well.

  • This PR adapts the mutating fields of the existing PSPs in the PodSpec.
  • Stop deploying PSPs if the plugin is disabled in the Shoot.

Which issue(s) this PR fixes:
Part of gardener/gardener#5250

Special notes for your reviewer:
/squash

Release note:

Please make sure you're running [email protected] or above before upgrading to this version.

@gardener-robot gardener-robot added area/networking Networking related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 16, 2022
@shafeeqes shafeeqes mentioned this pull request Aug 16, 2022
Closed
23 tasks
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 22, 2022
@shafeeqes shafeeqes marked this pull request as ready for review August 22, 2022 08:19
@shafeeqes shafeeqes requested review from a team as code owners August 22, 2022 08:19
ScheererJ
ScheererJ requested changes Aug 22, 2022
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt.

pkg/charts/utils.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Aug 22, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 22, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 22, 2022
ScheererJ
ScheererJ approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Aug 22, 2022
@ScheererJ ScheererJ merged commit 6995f1a into gardener:master Aug 22, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 22, 2022
@shafeeqes shafeeqes deleted the enh/podsecurity branch August 31, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/networking Networking related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shafeeqes @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot