Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced ops script #18

Merged
merged 6 commits into from
Dec 6, 2023
Merged

Enhanced ops script #18

merged 6 commits into from
Dec 6, 2023

Conversation

unmarshall
Copy link
Contributor

How to categorize this PR?

/area dev-productivity
/area ops-productivity
/kind enhancement

What this PR does / why we need it:
Introduces a new ops script which will now print all paths and popularly used etcd commands used by operators. Essentially a one stop shot for all things that an operator typically needs/executes.

Which issue(s) this PR fixes:
Fixes #17

Special notes for your reviewer:

Release note:

ops/print-etcd-cert-paths.sh has been removed and is now replaced with ops/print-etcd-cheatsheet.sh

@unmarshall unmarshall requested a review from a team as a code owner December 1, 2023 06:36
@gardener-robot gardener-robot added the needs/review Needs review label Dec 1, 2023
@unmarshall unmarshall marked this pull request as draft December 1, 2023 06:36
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 1, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 1, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 1, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 1, 2023
@aaronfern aaronfern marked this pull request as ready for review December 1, 2023 09:35
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 1, 2023
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Dec 1, 2023
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 1, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 1, 2023
@aaronfern
Copy link
Contributor

Thanks for the review @seshachalam-yv!
I've addressed your review comments. PTAL

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 1, 2023
shreyas-s-rao
shreyas-s-rao reviewed Dec 1, 2023
View reviewed changes
ops/Dockerfile Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronfern can you also please update the alpine image version in a separate PR?

shreyas-s-rao
shreyas-s-rao requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronfern @unmarshall thanks for this PR. Makes it really helpful for operators to run important etcd commands, with a simple copy-paste now.

Just one small comment, but overall LGTM.

docs/deployment/ops.md Outdated Show resolved Hide resolved
@shreyas-s-rao shreyas-s-rao added this to the v0.2.0 milestone Dec 1, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 4, 2023
shreyas-s-rao
shreyas-s-rao approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Dec 4, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 4, 2023
seshachalam-yv
seshachalam-yv approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaronfern aaronfern merged commit cc195ef into gardener:main Dec 6, 2023
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 6, 2023
@renormalize renormalize added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Oct 7, 2024
@gardener-robot gardener-robot removed the size/l Size of pull request is large (see gardener-robot robot/bots/size.py) label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees

@unmarshall unmarshall

Labels
area/dev-productivity Developer productivity related (how to improve development) area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

[Enhancement] Update ops script to include all etcd commands and relevant paths
9 participants
@unmarshall @aaronfern @shreyas-s-rao @seshachalam-yv @gardener-robot-ci-1 @renormalize @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot