Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring reasons: SBP-authored issues (storage, error handling), common naming convention (state names, errors, events, etc.)
Flow new features:
start
parameter forcreate_campaign
and scheduled campaign activation flow: Add start block to campaign creation #71MinCampaignDeposit
(first iteration: 10% of target and 1:1 GAME-to-PLAY conversion). Next iteration with oracles.CampaignDurationLimits
. Runtime configured using 24 hours - 60 days interval.Flow refactoring:
update_state
extrinsic, discussion -> Flow pallet #84 (reply in thread).create_campaign
reduced: O(log N) -> O(1).Campaign.created
Timestamp -> BlockNumber, discussion -> Unixtime #82 (reply in thread)Signal minor changes:
Discussion:
on_finalize
andon_initialize
hooks. Currently, Signal uses mostlyon_finalize
for calculations and Flow, on the contraryon_initialize
(probably I'll create a discussion).TODO:
on_initialize
benchmark validation has some weird issues.