Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks to Flow pallet #45

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Add benchmarks to Flow pallet #45

merged 2 commits into from
Jun 23, 2022

Conversation

vayesy
Copy link
Collaborator

@vayesy vayesy commented Jun 16, 2022

No description provided.

@vayesy vayesy requested review from 2075 and vovacha June 16, 2022 20:31
@vayesy vayesy self-assigned this Jun 16, 2022
@vayesy vayesy force-pushed the feature/benchmarks branch from a208070 to eeaaef4 Compare June 16, 2022 21:50
@vayesy vayesy force-pushed the feature/benchmarks branch from eeaaef4 to 1b246c9 Compare June 17, 2022 09:42
vovacha
vovacha reviewed Jun 20, 2022
View reviewed changes
flow/src/benchmarking.rs Outdated Show resolved Hide resolved
vovacha
vovacha reviewed Jun 20, 2022
View reviewed changes
flow/src/benchmarking.rs Outdated Show resolved Hide resolved
vovacha
vovacha reviewed Jun 20, 2022
View reviewed changes
flow/src/lib.rs Outdated Show resolved Hide resolved
vovacha
vovacha reviewed Jun 20, 2022
View reviewed changes
flow/src/lib.rs Outdated Show resolved Hide resolved
vovacha
vovacha suggested changes Jun 20, 2022
View reviewed changes
flow/src/lib.rs Outdated Show resolved Hide resolved
@vayesy vayesy marked this pull request as draft June 21, 2022 09:44
@vayesy vayesy marked this pull request as ready for review June 21, 2022 22:10
@vayesy vayesy force-pushed the feature/benchmarks branch from ea9e27c to 49374cc Compare June 21, 2022 22:15
@vayesy vayesy force-pushed the feature/benchmarks branch from 49374cc to 93f01d1 Compare June 22, 2022 09:27
vovacha
vovacha approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@vovacha vovacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

2075
2075 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@2075 2075 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vayesy vayesy merged commit dae261b into main Jun 23, 2022
@vayesy vayesy deleted the feature/benchmarks branch June 23, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vovacha vovacha vovacha approved these changes

@2075 2075 2075 approved these changes

Assignees

@vayesy vayesy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vayesy @2075 @vovacha