Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(control, signal): control genesis, refactoring #40

Merged
merged 6 commits into from
Jun 11, 2022
Merged

feat(control, signal): control genesis, refactoring #40

merged 6 commits into from
Jun 11, 2022

Conversation

vovacha
Copy link
Contributor

@vovacha vovacha commented Jun 3, 2022 •
edited
Loading

gamedao-control:

  • add genesis_build
  • small refactoring related to the do_create_org
  • create_org extrinsic: gov_asset and pay_asset change type u8 => CurrencyId
  • error OrgExists
  • InitialDepost -> MinimumDeposit, make deposit optional

gamedao-signal:

  • Proposal struct changes: context_id => org_id + option(campaign_id)
  • Storage ProposalsByContext* => ProposalsByOrg*. If needed, later could be also added: ProposalByType* or/and ProposalByCampaign*
  • create_proposal refactoring
  • migrations

global:

  • remove randomness, use hash(nonce) instead
  • remove gamedao-treasury pallet
  • remove redundant types: AdminOrigin, GameDAOAdminOrigin, etc.
  • tests

TESTING:

  • build OK
  • tests OK
  • migration OK

@vovacha vovacha marked this pull request as ready for review June 10, 2022 12:20
@vovacha vovacha requested review from vayesy and 2075 June 10, 2022 12:20
vayesy
vayesy reviewed Jun 10, 2022
View reviewed changes
signal/src/lib.rs Show resolved Hide resolved
control/src/lib.rs Outdated Show resolved Hide resolved
@vovacha
Copy link
Contributor Author

vovacha commented Jun 10, 2022

We also need migrations for gamedao-signal, since storage was changed.
Switching to draft again.

@vovacha vovacha marked this pull request as draft June 10, 2022 14:18
@vovacha vovacha changed the title feat(control): genesis feat(control, signal): control genesis, refactoring Jun 10, 2022
@vovacha vovacha marked this pull request as ready for review June 10, 2022 18:03
@vovacha vovacha merged commit f97272c into main Jun 11, 2022
@vovacha vovacha deleted the vovacha/feat/genesis-control branch June 11, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vayesy vayesy vayesy approved these changes

@2075 2075 Awaiting requested review from 2075

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vovacha @2075 @vayesy