Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not working with Eslint 8 #829

Closed
brunomacf opened this issue Jan 6, 2022 · 2 comments
Closed

Not working with Eslint 8 #829

brunomacf opened this issue Jan 6, 2022 · 2 comments
Labels
question

Comments

@brunomacf
Copy link

brunomacf commented Jan 6, 2022 •
edited
Loading

When running with eslint 8 i'm seeing this error:

error  This rule cannot yet be supported for ESLint 8; you should either downgrade to ESLint 7 or disable this rule. The possibility for ESLint 8 support is being tracked at https://github.com/eslint/eslint/issues/14745

Indeed eslint/eslint#14745 is still open but we have this #791 and this #792 which makes me think it should be working fine with ESlint 8. Am i missing something?
@brettz9
Copy link
Collaborator

brettz9 commented Jan 6, 2022

Note that the error is only for the rule jsdoc/check-examples. You have to currently disable that rule (at least until such time as eslint/eslint#14745 may be fixed). Otherwise, ESLint 8 support is fine.

Closing as that should answer, but feel free to comment further as needed.

@brettz9 brettz9 closed this as completed Jan 6, 2022
@brunomacf
Copy link
Author

Thanks a lot @brettz9!!

finchie added a commit to finchie/naturescot-utils that referenced this issue Oct 14, 2022
@finchie
update xo dependency to remove high vulnerability
5fd4404 
- add typescript & @typescript-eslint/eslint-plugin dependencies
- disable "jsdoc/check-examples" rule as per
gajus/eslint-plugin-jsdoc#829

Issue: Scottish-Natural-Heritage/Licensing#1500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettz9 @brunomacf