Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for UpdateContainerOptions #410

Merged

Conversation

paul-hansen
Copy link
Contributor

Removed kernel_memory which was deprecated in Docker's API version 1.41 and removed in 1.42.

Renamed nano_cp_us and io_maximum_i_ops in UpdateContainerOptions to nano_cpus and io_maximum_iops to match the naming in HostConfig. Closes #408

Changed the serde rename of nano_cpus from NanoCPUs to NanoCpus to match the Docker API.

@fussybeaver
Copy link
Owner

Thanks for the contribution

@fussybeaver fussybeaver merged commit 7daee4f into fussybeaver:master May 12, 2024
13 checks passed
@paul-hansen paul-hansen deleted the update-container-options branch July 31, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpdateContainerOptions has i_ops and cp_us instead of iops and cpus
2 participants