Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix winapi error #361

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Fix winapi error #361

merged 1 commit into from
Jan 6, 2024

Conversation

epompeii
Copy link
Contributor

@epompeii epompeii commented Jan 6, 2024

I get an error when running on Windows:

error[E0432]: unresolved import `winapi::shared::winerror`

Repro in this job: https://github.com/bencherdev/bencher/actions/runs/7432835880/job/20225107491#step:8:443

The fix for this is simple, adding winerror as a feature for winapi.

Let me know if you would like for me to create a follow on PR to add Windows builds to CI.

@fussybeaver
Copy link
Owner

Thanks for using it, let me fix CI that is failing on something unrelated and we can get this merged.

@fussybeaver
Copy link
Owner

I you could rebase, we can get the other tests to pass

@epompeii
Copy link
Contributor Author

epompeii commented Jan 6, 2024

No worries, thank you for the great crate! 😃
I've rebased on the latest master. Hopefully that works.

@fussybeaver fussybeaver merged commit bfedd5c into fussybeaver:master Jan 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants