fix: missing tty options in StartExecOptions

[leon3s]

Source: https://docs.docker.com/engine/api/v1.43/#tag/Exec/operation/ExecStart

[fussybeaver]

Thanks, I think we never added this parameter, because in my testing it didn't seem to affect the API output in any way - you'd need to wrap this endpoint in a pseudo tty library and a command-line interface to actually make it act like a tty.

Now I'm checking the underlying moby code, it looks like the tty parameter sets a different response content type? https://github.com/moby/moby/blob/fa2f6f98beb4d9d6fd814e63c28cefac7f90ccbc/api/server/router/container/exec.go#L122

Are you finding this parameter useful?

[leon3s]

Hey yes, instead of returning a Stream where docker write for each stdout and stderr the number 0 or 1 to specify what kind of output is. It write all the output directly. It also add colors and detach keys as the behavior differt when the command write in a tty.
You can test the behavior of this using docker cli.

docker run -dt --name test-exec alpine:latest
# No colors
docker exec test-exec ls -l --color=auto /
# With colors
docker exec -t test-exec ls -l --color=auto /

Also any reason to not use this structure ? because it's seems unused

bollard/codegen/swagger/src/models.rs

Line 2127 in 6ecdb14

pub struct ExecStartConfig {

[fussybeaver]

I guess the same could be asked about other options like

bollard/codegen/swagger/src/models.rs

Line 886 in 6ecdb14

pub struct ContainerConfig {

and there are probably others..

It's probably a good idea to use the generated type in these cases 👍

Edit: I think it's because of the use of T: Into<String>... something we should probably remove in the long run

[fussybeaver]

I'll merge this for now, can think about using the generated types