Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: try/with, string operations, primes #20

Merged
merged 10 commits into from
Oct 20, 2023
Merged

feat!: try/with, string operations, primes #20

merged 10 commits into from
Oct 20, 2023

Conversation

SpiralOSS
Copy link
Collaborator

No description provided.

@SpiralOSS SpiralOSS mentioned this pull request Oct 19, 2023
grammar correction

Co-authored-by: Ruben Bartelink <[email protected]>
Copy link
Member

@bartelink bartelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good - will merge if/when resolved, or let me know if you prefer to do that yourself
(I dont think there needs to be a restriction on merging - follow-up PRs can revisit things, in the interests of having few outstanding PRs and little to no rebasing/merging etc)

docs/fsharp-cheatsheet.md Show resolved Hide resolved
docs/fsharp-cheatsheet.md Outdated Show resolved Hide resolved
docs/fsharp-cheatsheet.md Outdated Show resolved Hide resolved
docs/fsharp-cheatsheet.md Show resolved Hide resolved
docs/fsharp-cheatsheet.md Outdated Show resolved Hide resolved
@SpiralOSS
Copy link
Collaborator Author

SpiralOSS commented Oct 20, 2023

@bartelink I named this PR "Updates"; and I noticed on our last PR, you changed the name and prefixed with "feat!" and named it slightly different. Is there some doco on naming practices? (Before I merge this one)

@bartelink
Copy link
Member

bartelink commented Oct 20, 2023

Is there some doco on naming practices

https://www.conventionalcommits.org/en/v1.0.0/

Very annoying/wierd for about 2 days, then you can't stop yourself

TL;DR, composed of

  1. task code (e.g.: feat/chore/fix)
  2. (area) (optional)
  3. ! (if breaking)
  4. :
  5. description that does not repeat any of the previous

e.g.:

  • feat(Quotes): Explain triple quotes
  • fix(Patterns): Handle malformed inputs
  • feat(Patterns)!: Remove usage of fst/snd
  • chore: update runner versions

In the context of code, the ! (breaking) indicator would mean a semver interface change or a dependency on an new mandatory env var

In the context of this repo, ! would mean a subjective rewrite of something

In prod code in more normal repos:

chore(deps): Update json libs
fix(Profile): Render name correctly
fix(Host)!: Require DB server name via DB_SERVER_NAME

Dividing line between chore/feat/fix can be subjective

But in general feat is adding a new capability
And chore is yak shaving

@bartelink
Copy link
Member

I named this PR "Updates";

conventional commits also nudges toward SRP for PRs - i.e. there's no good name for this grab bag of stuff (not saying it needs to be split as long as its not in flight for long and you are the maintainer after all!)

@SpiralOSS SpiralOSS changed the title Updates feat!:try/with, string operations, primes Oct 20, 2023
@SpiralOSS SpiralOSS merged commit 1840d11 into fsprojects:master Oct 20, 2023
@SpiralOSS SpiralOSS deleted the updates branch October 20, 2023 14:33
@bartelink bartelink changed the title feat!:try/with, string operations, primes feat!: try/with, string operations, primes Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants