-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: try/with, string operations, primes #20
Conversation
grammar correction Co-authored-by: Ruben Bartelink <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good - will merge if/when resolved, or let me know if you prefer to do that yourself
(I dont think there needs to be a restriction on merging - follow-up PRs can revisit things, in the interests of having few outstanding PRs and little to no rebasing/merging etc)
Grammar correction Co-authored-by: Ruben Bartelink <[email protected]>
@bartelink I named this PR "Updates"; and I noticed on our last PR, you changed the name and prefixed with "feat!" and named it slightly different. Is there some doco on naming practices? (Before I merge this one) |
https://www.conventionalcommits.org/en/v1.0.0/ Very annoying/wierd for about 2 days, then you can't stop yourself TL;DR, composed of
e.g.:
In the context of code, the In the context of this repo, In prod code in more normal repos: chore(deps): Update json libs Dividing line between chore/feat/fix can be subjective But in general feat is adding a new capability |
conventional commits also nudges toward SRP for PRs - i.e. there's no good name for this grab bag of stuff (not saying it needs to be split as long as its not in flight for long and you are the maintainer after all!) |
No description provided.