Skip to content

Commit

Permalink
Don't clear packages folder during convert-from-nuget - our own paket…
Browse files Browse the repository at this point in the history
… might live there - #105
  • Loading branch information
forki committed Sep 18, 2014
1 parent 48d089c commit 7c5c9ba
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 3 additions & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
#### 0.2.1 - 18.09.2014
* Don't clear packages folder during convert-from-nuget - our own paket might live there

#### 0.2.0 - 17.09.2014
* Allow to directly link GitHub files - http://fsprojects.github.io/Paket/github_dependencies.html
* Automatic NuGet conversion - http://fsprojects.github.io/Paket/convert_from_nuget.html
Expand Down
4 changes: 0 additions & 4 deletions src/Paket/Process.fs
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,4 @@ let ConvertFromNuget() =

tracefn "Deleted \"%s\"" packageFile.FullName

if Directory.Exists(".\packages") then
CleanDir ".\packages"
trace "Cleared .\packages directory"

Install(false, false, true, "paket.dependencies")

2 comments on commit 7c5c9ba

@theimowski
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't care if the NuGet-resolved packages will stay there?
Maybe we should invoke Install --force --hard after convert-from-nuget to ensure the package dir gets overwritten?

@forki
Copy link
Member Author

@forki forki commented on 7c5c9ba Sep 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I really don't care - usally this folder is gitignored.

My problem was Paket also lives there and this code will try to delete running paket process. And fails.

Hard force might have the same issue.

Please sign in to comment.