Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ValueOption #521

Merged
merged 6 commits into from
Nov 28, 2022

Conversation

fcallejon
Copy link
Member

No description provided.

@fcallejon fcallejon force-pushed the fcallejon/add-valueoption branch from fe91dbe to b11746c Compare November 20, 2022 22:13
@fcallejon fcallejon marked this pull request as ready for review November 20, 2022 22:42
Copy link
Member

@gusty gusty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@@ -30,6 +30,7 @@
<ItemGroup>
<Compile Include="Internals.fs" />
<Compile Include="Extensions/Option.fs" />
<Compile Include="Extensions\ValueOption.fs" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bar is \ instead of /

FSharpPlus.sln Outdated
@@ -77,6 +77,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "content", "content", "{8E6D
docsrc\content\type-writert.fsx = docsrc\content\type-writert.fsx
docsrc\content\type-ziplist.fsx = docsrc\content\type-ziplist.fsx
docsrc\content\types.fsx = docsrc\content\types.fsx
docsrc\content\type-valueoptiont.fsx = docsrc\content\type-valueoptiont.fsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it up :)

@gusty gusty requested a review from wallymathieu November 23, 2022 10:57
@gusty gusty changed the title Add functions for ValueOption Add support for ValueOption Nov 23, 2022
@gusty gusty merged commit e3f71e8 into fsprojects:master Nov 28, 2022
@fcallejon fcallejon deleted the fcallejon/add-valueoption branch November 18, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants