-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest F# Formatting #372
Update to latest F# Formatting #372
Conversation
docsrc/content/_template.html
Outdated
@@ -4,16 +4,16 @@ | |||
<meta charset="utf-8"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this template does not work well, since It's not the one that @adz has fixed. This is simply the minimal effort conversion of template.cshtml to html.
This reverts commit fa02850.
Co-authored-by: Adam Davies <[email protected]>
I've rendered the docs here: |
@@ -193,7 +194,7 @@ let getValidPassword : ResultT<_> = | |||
let askPassword = monad { | |||
do! lift <| putStrLn "Insert your new password:" | |||
let! value = getValidPassword | |||
do! lift <| putStrLn "Storing in database..." | |||
//do! lift <| putStrLn "Storing in database..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this caused an error? ..or maybe it was unintentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking locally, I got:
docsrc/content/abstraction-monad.fsx: error(197,8)-(197,53) Type constraint mismatch when applying the default type 'obj' for a type inference variable. The type 'obj' does not support the operator 'Lift' Consider adding further type constraints
Adding type constraint didn't help -- I got "Value restriction".
Changing lift
-> liftAsync
doesn't help either.
I resolved it by passing unit:
let askPassword () = monad {
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should apply your fix to the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge. Some of the doc issues may have been present before, or not, but we can resolve separately. They still generate a doc.
* Update to latest F# Formatting * Using fsdocs tool * Fix for type inference issues * Sample compilation error in fsx added to tests * F# markdown content instead of evaluation * Use template from @adz branch Co-authored-by: Adam Davies <[email protected]>
The goal is to be able to upgrade to the latest F# Formatting as seen in #369 but keep the possibility to deploy docs and use the plantuml diagram.