Details improvements #917
Merged
Details improvements #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Keep member name aligned to the top left (i.e., don't shift around when details are expanded). * Put marker back before the summary. * Make the table readable on mobile by wrapping rows when too narrow.
|
Visually looks great to me.
Thanks! I had noticed that regression as well but was too lazy to fix. |
|
Thanks for doing this! I'll try and review this when I can. It might take me a couple of days as I'm travelling. |
* ...I think this looks better, especially when the summary is multiline.
nojaf
approved these changes
May 31, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (part of) #916.
Auto-expand the details of the selected member, including when linked directly to (via the fragment portion of the URL).
scroll_to_and_expand.mp4
Keep member name aligned to the top left, i.e., don't shift around when details are expanded. This was the original behavior in Memberdocs #818.
stay.mp4
Put the details marker back before the summary. (This is how it was before and how
detailsnormally works... The arrow on its own line as it is inmainlooks very odd to me.)Make the table readable on mobile by wrapping rows when the screen is too narrow.
wrap.mp4
Align copy icons, etc., to flex-start instead of center to match member name alignment
Before
After