Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minimal seo tags for open graph and twitter cards to default template #873

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

kMutagene
Copy link
Contributor

see #869

This is a basic implementation using the available substitution parameters. There could be more, e.g. displaying a default image etc., but i think for that we would need additional substitutions.

@Thorium
Copy link
Member

Thorium commented Nov 17, 2023

Is there something good that could be added to the meta description tag?

@nojaf
Copy link
Collaborator

nojaf commented Nov 17, 2023

Maybe we can use the Description tag from the cracked projects?

@kMutagene
Copy link
Contributor Author

Maybe we can use the Description tag from the cracked projects?

I was thinking about that, but this has the same problem as fsdocs-authors has - if the respective xml tag in the cracked project does not exist, the tag will contain rubbish. However i agree that that tag would be a sensible default when it exists.

@nojaf
Copy link
Collaborator

nojaf commented Nov 17, 2023

We could also fix that part. Having better defaults or use empty strings if not replaced. Or let the tool crash in a strict mode if values are missing.

@nojaf nojaf mentioned this pull request Nov 20, 2023
@nojaf nojaf mentioned this pull request Nov 30, 2023
@nojaf nojaf merged commit 234c80e into fsprojects:main Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants