One fsiEvaluator per docs file #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am pretty sure this fixes #737. Instead of creating one
fsiEvaluatorper docs build, I movedfsiEvaluatorcreation inside theprocessFilefunction. Thus, one evaluator per file.Anecdotally, I have a site with lots of docs files that has been stuck on fsdocs version 15.0.0. Any version$\ge15.0.1$ caused the fsdocs build process to fail with a stack overflow that seemed to be related to collecting script parsing/fsc results in a list. With this PR, the site finally builds on a recent fsdocs version.